Skip to content

GitLab

Closed
Created by Ondřej Surý@ondrejOwner0 of 2 tasks completed0/2 tasks

Follow-up from "Remove ECS authoritative implementation from BIND"

The following discussions from !219 (merged) should be addressed:

  • @ondrej started a discussion:

    Could we either use a #define from the header or sizeof(node_num)/sizeof(node_num[0]) for all occurrences of 2 meaning the number of elements in this particular array?

  • @ondrej started a discussion: (+1 comment)

    Since the data stored here are being simplified, why can't we have:

    • ipv4_node_num and ipv4_data
    • ipv6_node_num and ipv6_data

    I don't have the full picture here, but the generic names are confusing to me (especially when used in acl.c).

    The other reader-friendly option (requiring less code changes) would be to add:

    #define IPV4_INDEX 0
#define IPV6_INDEX 1

    and use it consistently in the code using radix.h

Edited by Evan Hunt