Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 525
    • Issues 525
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 101
    • Merge requests 101
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #293

Closed
Open
Created May 25, 2018 by Ondřej Surý@ondrejOwner0 of 2 tasks completed0/2 tasks

Follow-up from "Remove ECS authoritative implementation from BIND"

The following discussions from !219 (merged) should be addressed:

  • @ondrej started a discussion:

    Could we either use a #define from the header or sizeof(node_num)/sizeof(node_num[0]) for all occurrences of 2 meaning the number of elements in this particular array?

  • @ondrej started a discussion: (+1 comment)

    Since the data stored here are being simplified, why can't we have:

    • ipv4_node_num and ipv4_data
    • ipv6_node_num and ipv6_data

    I don't have the full picture here, but the generic names are confusing to me (especially when used in acl.c).

    The other reader-friendly option (requiring less code changes) would be to add:

    #define IPV4_INDEX 0
    #define IPV6_INDEX 1

    and use it consistently in the code using radix.h

Edited May 25, 2018 by Evan Hunt
Assignee
Assign to
Time tracking