Follow-up from "Remove ECS authoritative implementation from BIND"
The following discussions from !219 (merged) should be addressed:
-
@ondrej started a discussion: Could we either use a
#define
from the header orsizeof(node_num)/sizeof(node_num[0])
for all occurrences of2
meaning the number of elements in this particular array? -
@ondrej started a discussion: (+1 comment) Since the data stored here are being simplified, why can't we have:
-
ipv4_node_num
andipv4_data
-
ipv6_node_num
andipv6_data
I don't have the full picture here, but the generic names are confusing to me (especially when used in
acl.c
).The other reader-friendly option (requiring less code changes) would be to add:
#define IPV4_INDEX 0 #define IPV6_INDEX 1
and use it consistently in the code using
radix.h
-
Edited by Evan Hunt