Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 610
    • Issues 610
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !6876

[v9_18] Fix ns_statscounter_recursclients counting bug

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Arаm Sаrgsyаn requested to merge 3584-ns_statscounter_recursclients-bug-v9_18 into v9_18 Oct 07, 2022
  • Overview 7
  • Commits 3
  • Pipelines 6
  • Changes 4

Previously 'ns_statscounter_recursclients' was not being counted for prefetch and rpzfetch fetches, but later that was changed in f7482b68 and now the code in 'lib/ns/query.c' does increment and decrement the counter also during prefetch and rpzfetch, but the code in 'lib/ns/client.c:ns_client_endrequest()' was not adjusted accordingly.

Remove the condition in 'ns_client_endrequest()' when decrementing the counter.

Closes #3584 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3584-ns_statscounter_recursclients-bug-v9_18