Skip to content

fix: dev: Attach/detach to the listening child socket when accepting TLS

Ondřej Surý requested to merge 4833-tlssock-needs-to-attach-to-child-tlslistener into main

When TLS connection (TLSstream) connection was accepted, the children listening socket was not attached to sock->server and thus it could have been freed before all the accepted connections were actually closed.

In turn, this would cause us to call isc_tls_free() too soon - causing cascade errors in pending SSL_read_ex() in the accepted connections.

Properly attach and detach the children listening socket when accepting and closing the server connections.

Closes #4833 (closed)

Merge request reports