Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Kea
Kea
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 457
    • Issues 457
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 76
    • Merge Requests 76
  • Operations
    • Operations
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • KeaKea
  • Issues
  • #656

Closed
Open
Created Jun 06, 2019 by Francis Dupont@fdupontDeveloper

Need more checks on global parameters.

Reference #576 (comment 61000) second problem: invalid values for global parameters should be rejected even they are not used:

  • for individual parameters, e.g. next-server sets to something not parse-able as an IPv4 address (nor empty)
  • between parameters, e.g. 0 <= t1_percent <= 1 and t1_percent < t2_percent

The ideas are:

  • avoid cases where the config backend is used to create a configuration which can't be saved and reloaded (get then set or write then reload fails)
  • avoid cases where a global parameter with an invalid value is added/accepted and the invalid will raise an error a long time ago when an update will first use it (e.g. configuration built incrementally starting by global parameters, IMHO could be a popular way to proceed).

To summary the current check on global parameter value type is fine but not enough. Related to #576 (closed), #535 (closed) and #513

Edited Jun 13, 2019 by Francis Dupont
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Kea1.9-backlog
Milestone
Kea1.9-backlog
Assign milestone
Time tracking
None
Due date
None