Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • stork stork
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 292
    • Issues 292
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 28
    • Merge requests 28
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • storkstork
  • Merge requests
  • !390

Resolve "bump up version command doesn't work on MacOS"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Andrei Pavel requested to merge 651-bump-up-version-command-doesn-t-work-on-macos into master Dec 23, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

Closes #651 (closed).

I thought this was an easy fix in shell, but ended up migrating everything to Ruby. This should be portable enough.

The problem manifested in FreeBSD 13 too. Tested on Linux and in FreeBSD 13 and it works on both. Preferably review this on a MacOS.

I tried to minimize duplicate code. Created task bump at first. Then realized this could have been a simple function and not available to the end user, but I left it like that in the end. I have no strong preference regarding this matter. So now rake bump[1.1.0] is a possible task.

This MR also contains an extra change of restarting nginx when deploying the demo. nginx needing a restart was something that fixed the demo recently.

Edited Jan 27, 2022 by Andrei Pavel
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 651-bump-up-version-command-doesn-t-work-on-macos